This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
Document dynamic changesetTemplates and steps.outputs #17286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
3 tasks
9e457fa to
4000d42
Compare
|
Notifying subscribers in CODENOTIFY files for diff c0c43b7...805b804.
|
eseliger
approved these changes
Jan 18, 2021
Co-authored-by: Erik Seliger <erikseliger@me.com>
LawnGnome
approved these changes
Jan 18, 2021
Co-authored-by: Adam Harvey <aharvey@sourcegraph.com>
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request does multiple things:
steps.outputsin campaign spec reference with lots of examples to show how they workchangesetTemplatefields now allow templating in campaign spec referenceoutputsin campaign spec templating docchangesetTemplatein campaign spec templating docI also decided to do the following:
Experimentalbadge next to "Campaign spec templating"Experimentalbadge next to fields in campaign spec YAML reference to aTemplatingbadge that links to the templating page. That looks like this:Why remove the
Experimentalbadge? I think templating is here to stay and features (such as dynamic changeset templates) build on top of it. Having the experimental badge might scare users off, which is bad, since a lot of cool things (e.g.: only run commands over matched files) are possible with templating. And while we will surely update it and/or might make drastic changes to it in the future, that's not different to any other features we currently have.