Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

Commit

Permalink
release: remove xDaysBeforeRelease, unify issue and timelines (#17401)
Browse files Browse the repository at this point in the history
* Remove `xDaysBeforeRelease` and associated features (calendar events, template args, etc)
* Unify generation of issues and calendar events, as well as things like release naming. Previously this was rather brittle to change and had a lot of code duplication
* Other improvements:
  * `tracking:issues` now handles _all_ tracking issue generation
  * Calendar dry run
  * Backlinks to "parent" issue for child issues related to a release
  * Update patch request issue
  • Loading branch information
bobheadxi authored Jan 20, 2021
1 parent 2a9c509 commit 11a81d1
Show file tree
Hide file tree
Showing 7 changed files with 214 additions and 315 deletions.
4 changes: 2 additions & 2 deletions .github/ISSUE_TEMPLATE/request_patch_release.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ I have read [when and why we perform patch releases](https://about.sourcegraph.c

- If there is [already an upcoming patch release](https://github.com/sourcegraph/sourcegraph/issues?q=is%3Aissue+label%3Arelease-tracking+), add the listed commits alongside a link to this issue
- If there is no upcoming patch release, create a new one:
- Update [`dev/release/release-config.jsonc`](https://sourcegraph.com/github.com/sourcegraph/sourcegraph/-/blob/dev/release/release-config.jsonc) with the patch release in `upcomingRelease` (and open a PR to `main` to update it)
- `cd dev/release && yarn build && yarn run release tracking:patch-issue`
- Update [`dev/release/release-config.jsonc`](https://sourcegraph.com/github.com/sourcegraph/sourcegraph/-/blob/dev/release/release-config.jsonc) with the patch release in `upcomingRelease` and `releaseDate` (and open a PR to `main` to update it)
- `yarn release tracking:issues`
- Add the listed commits alongside a link to this issue to the generated [release tracking issue](https://github.com/sourcegraph/sourcegraph/issues?q=is%3Aissue+label%3Arelease-tracking+)

Comment and close this issue once the relevant commit(s) have been cherry-picked into the release branch.
8 changes: 3 additions & 5 deletions dev/release/release-config.jsonc
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,8 @@
"upcomingRelease": "3.24.0",

// Release dates
"releaseDate": "20 January 2021 10:00 PST",
"oneWorkingDayAfterRelease": "21 January 2021 10:00 PST",
"releaseDateTime": "20 January 2021 10:00 PST",
"oneWorkingDayBeforeRelease": "19 January 2021 10:00 PST",
"fourWorkingDaysBeforeRelease": "15 January 2021 10:00 PST",
"fiveWorkingDaysBeforeRelease": "14 January 2021 10:00 PST",

// Channel where messages from the tooling are posted
"slackAnnounceChannel": "dev-announce",
Expand All @@ -37,6 +34,7 @@
"dryRun": {
"tags": false,
"changesets": false,
"trackingIssues": false
"trackingIssues": false,
"calendar": false
}
}
6 changes: 2 additions & 4 deletions dev/release/src/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,7 @@ export interface Config {
previousRelease: string
upcomingRelease: string

releaseDateTime: string
oneWorkingDayBeforeRelease: string
fourWorkingDaysBeforeRelease: string
fiveWorkingDaysBeforeRelease: string
releaseDate: string
oneWorkingDayAfterRelease: string

slackAnnounceChannel: string
Expand All @@ -27,6 +24,7 @@ export interface Config {
tags?: boolean
changesets?: boolean
trackingIssues?: boolean
calendar?: boolean
}
}

Expand Down
Loading

0 comments on commit 11a81d1

Please sign in to comment.