Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a single self-contained docker image, remove alpine #389

Merged
merged 4 commits into from
Dec 11, 2024

Conversation

antonsviridov-src
Copy link
Contributor

@antonsviridov-src antonsviridov-src commented Dec 6, 2024

  • Remove Alpine-based docker base as this forces us to use unofficial node builds: https://github.com/sourcegraph/sourcegraph/pull/2164/files, it might carry no risk, but also it isn't obvious to me what we gain from reduced image size
  • Make docker build self-contained - it will bootstrap the version of scip-typescript it's built on, instead of relying on NPM publishing
  • Start publishing docker images with :latest-snapshot on main branch builds, for easier testing and to be able to point customers to it
  • Ensure we use a manfiest SHA in docker base, so that docker automatically pulls a amd64/arm64 image

Test plan

  • existing CI

@antonsviridov-src antonsviridov-src marked this pull request as ready for review December 9, 2024 11:25
Comment on lines -46 to -48
file: Dockerfile.autoindex
push: true
tags: sourcegraph/scip-typescript:autoindex
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need a corresponding change in sg/sg to change the image we use for autoindexing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I will update the SHA in sg/sg to the sha of the new container (single one).
We only refer to indexing containers by sha, not name (in default settings anyways)

Copy link
Contributor

@kritzcreek kritzcreek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antonsviridov-src antonsviridov-src merged commit 0473c4a into main Dec 11, 2024
7 checks passed
@antonsviridov-src antonsviridov-src deleted the self-contained-docker-image branch December 11, 2024 10:38
@antonsviridov-src antonsviridov-src restored the self-contained-docker-image branch December 11, 2024 10:39
@antonsviridov-src antonsviridov-src deleted the self-contained-docker-image branch December 11, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants