-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for Preview URL Redirects, CSS Asset Fetching, and Post-Merge Preview URL Availability #96
Conversation
@Numbers88s I'm excited to see this new docs Preview in action. Can you make a PR with a docs change and add me and Maedah can see it? |
@csells Yes we can definitely do that, but not at the moment. We would need this PR merged on main first, since it updates the templates needed for this to work. I can merge the work and then make a change and tag you both, if that works ✌️ |
Perfect! |
if err != nil { | ||
return nil, err | ||
} | ||
return &subdirFileSystem{fs: c, path: "_resources/" + dir}, nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might want to use filepath.Join
here unless there's a reason unix filepaths are always alright (I think this is true for go-embed, for example).
Summary:
This PR addresses several bugs associated with our URL handling and asset fetching:
Changes:
Testing:
DEBUG
variable is set to true incmd/docsite/site.go
line 174
to mimic production enviromentcmd/docsite
directory rungo build .
doc/serve.sh
file change the $docsite variable to point to your local build of docsite. (my$docsite
variable looks like this 👉docsite_bin=/Users/<name>/go/src/docsite/cmd/docsite/docsite
sg run docsite
http://localhost:5080/@mrn-docs-preview
Request for Review:
I would appreciate it if team members could pull this branch and validate these fixes in their respective environments. Any feedback or potential edge cases that haven't been covered would be immensely valuable.
Thanks for your time, and looking forward to the feedback!