Check versioned requests that 404 for possible redirects #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At present, versioned requests do not get parsed for redirects, which causes issues when we have /help links in Sourcegraph that depend on a redirect being in place. As redirects are defined on the asset VFS, we can't trivially check the redirects for that specific version, but as a fallback, we can see if there are any current redirects that might help. This addresses (but doesn't actually fix) sourcegraph/sourcegraph#17931.
mrnugget
approved these changes
Feb 3, 2021
eseliger
approved these changes
Feb 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, versioned requests do not get parsed for redirects, which causes issues when we have /help links in Sourcegraph that depend on a redirect being in place. As redirects are defined on the asset VFS, we can't trivially check the redirects for that specific version, but as a fallback, we can see if there are any current redirects that might help.
This should be generally harmless, but helps us address old versions of Sourcegraph with redirect links that we now cannot update.
This addresses (but doesn't completely fix) sourcegraph/sourcegraph#17931.