Use first heading for title #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sqs how does this get deployed to the handbook? I'm still seeing no title on https://about.sourcegraph.com/handbook/engineering/web |
|
Nvm figured it out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Markdown pages can have content before the first heading, e.g. HTML tags containing a floated image, a style tag, a script, etc. This causes the page to show up as "Untitled" in search, see e.g. sourcegraph/about#1892. I've also seen this with some other pages. Comments were explicitly handled but all other tags were not. This changes it to simply use the first level-1 heading it can find, no matter if there are any other tags before it.