markdown: really fix soft line break rendering (#95)

sourcegraph · Mar 28, 2023 · a1bbaa9 · a1bbaa9
1 parent f439075
commit a1bbaa9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/markdown/extender.go b/markdown/extender.go
@@ -173,10 +173,12 @@ func (r *nodeRenderer) RegisterFuncs(reg renderer.NodeRendererFuncRegisterer) {
 		}
 
 		n := node.(*ast.Text)
+		if n.SoftLineBreak() {
+			defer func() { _ = w.WriteByte('\n') }()
+		}
+
 		text := n.Text(source)
 		if len(text) == 0 {
-			// Simply write a line break if there is no text in the node, otherwise, soft break lines are sticking.
-			_ = w.WriteByte('\n')
 			return ast.WalkContinue, nil
 		}
 

diff --git a/markdown/markdown_test.go b/markdown/markdown_test.go
@@ -134,8 +134,7 @@ func TestRenderer(t *testing.T) {
 			if err != nil {
 				t.Fatal(err)
 			}
-			want := `<h1 id="b"><a name="b" class="anchor" href="#b" rel="nofollow" aria-hidden="true" title="#b"></a>a
-</h1>
+			want := `<h1 id="b"><a name="b" class="anchor" href="#b" rel="nofollow" aria-hidden="true" title="#b"></a>a</h1>
 `
 			if string(doc.HTML) != want {
 				t.Errorf("got %q, want %q", string(doc.HTML), want)