DeepCody: clean up and fix stream #5815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hitesh-1997
approved these changes
Oct 4, 2024
vscode/src/chat/agentic/DeepCody.ts
Outdated
| public async getContext( | ||
| chatAbortSignal: AbortSignal, | ||
| loop = 2, | ||
| maxNewItems = 20 |
There was a problem hiding this comment.
nit: can we put a comment why we decide these numbers and see if they can be constant somewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX: https://sourcegraph.slack.com/archives/C07CNJTGB3Q/p1727983740644479
Updated to wait for streaming is done before starting the context retrieval process.
Also included some minor refactoring on namings
Test plan
Check the output channel to verify each tool is only run once after the streaming is completed.
Changelog