Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

releases: remove manual changelog check, add new changelog workflow #1659

Merged
merged 4 commits into from
Oct 6, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions handbook/engineering/releases/release_issue_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,10 @@ Arguments:

## $FOUR_WORKING_DAYS_BEFORE_RELEASE (4 work days before release): Branch cut

- [ ] Verify for each CHANGELOG item the following (if any item does not have these, disable it,
notify the owner, and remove it from the CHANGELOG):
- It has an owner attached to it
- It has undergone manual QA (and the QA was done on k8s.sgdev.org or at scale if the feature requires it).
- It is covered by the regression test suite
- [ ] Add a new section `## $MAJOR.MINOR` to [CHANGELOG.md](https://github.com/sourcegraph/sourcegraph/blob/main/CHANGELOG.md#unreleased) immediately under `## Unreleased changes`. Add new empty sections under `## Unreleased changes` ([example](https://github.com/sourcegraph/sourcegraph/pull/2323)).
- [ ] Commit this CHANGELOG edit to `main` using a PR.
- [ ] Update the changelog and merge the generated pull request:
```
yarn run release changelog:cut $MAJOR.$MINOR.0
```
- [ ] Create the `$MAJOR.$MINOR` branch off the CHANGELOG commit in the previous step: `git branch $MAJOR.$MINOR && git push origin $MAJOR.$MINOR`.
- [ ] Tag and announce the first release candidate:
```
Expand Down