This repository has been archived by the owner on May 24, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes updates for sourcegraph/about#5173 via sourcegraph/about#5175 |
katjuell
suggested changes
Mar 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things look good! A few things, though:
- We've got a lot of errors and warnings at this point, mainly from the animated logos component (and one on the
use-cases
index) that we should resolve:
✖ 135 problems (72 errors, 63 warnings)
35 errors and 0 warnings potentially fixable with the `--fix` option.
- Static builds currently fail, so we should resolve that:
$ next build && next export
Failed to compile.
./src/components/CustomerLogosSectionAnimated.tsx:214:30
Type error: Property 'height' does not exist on type 'GlobalEventHandlers'.
212 | const imageRef = new Image()
213 | imageRef.onload = function () {
> 214 | if (this.height && this.width) {
| ^
215 | let calculatedWidth = (this.width / this.height) * 50
216 | if (calculatedWidth > 135) calculatedWidth = 135
217 | setImagesWidth(prevState => (prevState += calculatedWidth + 70)) //Total width of all images
error Command failed with exit code 1.
Merged
@katjuell I've decided to remove the logos section temporarily since we have homepage updates underway. I don't think it's worth it to revise the current implementation since I'm anticipating a rewrite for this component as soon as this homepage updates are finalized. I've left a |
katjuell
approved these changes
Mar 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@katjuell yeah it was the logos section 🙃 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14 - 404 and use cases page
Note: I'll have to port over changes from 5170 and 5173 once those are merged in about...