This repository has been archived by the owner on May 24, 2022. It is now read-only.
Add terms pages and Markdown/ MDX parsing #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katjuell
commented
Mar 7, 2022
katjuell
commented
Mar 7, 2022
katjuell
commented
Mar 7, 2022
katjuell
commented
Mar 7, 2022
katjuell
commented
Mar 7, 2022
src/components/Actions/GetSourcegraphNowActions/getSourcegraphNowActions.module.scss
Show resolved
Hide resolved
katjuell
commented
Mar 7, 2022
| [index: string]: string | ||
| } | ||
|
|
||
| const EmbeddedHubSpot: FunctionComponent<EmbeddedHubSpotProps> = ({ portalId, formId, targetId, region }) => ( |
There was a problem hiding this comment.
See PR comment for overall tl;dr on how/ why this is distinct from createHubSpotForm.
bretthayes
reviewed
Mar 7, 2022
src/components/Actions/GetSourcegraphNowActions/getSourcegraphNowActions.module.scss
Show resolved
Hide resolved
bretthayes
reviewed
Mar 7, 2022
bretthayes
reviewed
Mar 8, 2022
Merged
bretthayes
suggested changes
Mar 9, 2022
bretthayes
approved these changes
Mar 9, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15 and #16 by adding terms pages and components. Also closes #19 by adding MD/ MDX parsing/ rendering.
NB: Adds a HubSpot embedded component to handle the fact that we can't drop
scripttags straight into our MD anymore. The component mirrors the minimal form implementation in this document and this document.Worth noting: The "autofill" behavior that we see on the injected HubSpot forms on prod, in
/securityand/subprocessors, specifically, is not present/ active on local Gatsby dev or Gatsby build, so I'm not dealing with that here. I'm assuming there is some logic that maps to our domain for these specific forms. This is not to be confused with thecreateHubSpotFormfunction which gets loaded into various pages. This PR deliberately doesn't port that, since that function is not used in MD files and will be handled separately in #25.Also, this PR does not handle code syntax — therefore, code blocks will not look as they currently do in prod. This will be covered by sourcegraph/about#5382.
To Test
npm citermsin thecontentdirectory (the directory where our Markdown will live). Ensure that there are no errors or warnings relating to our Markdown parsing.