System tray icon #868
Open
System tray icon #868
+157
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed |
|
Could anyone check how it works on MacOS? @love-linger? My goal is to make it staying in dock and keep running when window closing button is clicked. Unfortunately, I cannot check it myself. |
4bcf01c to
329650e
Compare
Add code for creation of system tray icon, menu and handle menu events
only first launched instance creates system tray icon and does not quit
329650e to
a3d1f78
Compare
|
Please, check this PR on MacOS |
|
I'm sorry. As I said in Discussions #805, there's no plan to add this feature into |
|
Ok. I understand that you don't want to invest your time in this feature. If you are worried that you will have to support this feature, then, please, don't. I'm not going to disappear. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #805
General description
When this feature is enabled, first launched instance of SourceGit doesn't quit when window closing button is pressed. Instead it hides in system tray and stays running.
This feature can be enabled or disabled either from "Preferences" dialog (menu -> Preferences -> Appearance) or by manually editing
preference.jsonfile.Implementation details
Window hiding
Sourcegit intercepts
OnClosingevent, cancels it and callsHideinstead (link to code)Preventing from creation of several system tray icons
When another instance of the SourceHGit is launched from the command line or from the system launcher, it will create another identical icon in the system tray, if no additional checking is performed.
To prevent this, every SourceGit instance tries to create a lock file in the system temporary directory (link to code). If this operation fails, it means that another SourceGit is running and the system tray icon is already created. In this case, no system tray icons are created, and
OnClosingevent causes exit.On MacOS no lock file is created, thus relying on the OS guarantees to launch only one instance of a packaged application.
Why?
Because opening application that is already running is still much faster than launch a new instance.
Note
Tested on Windows and Linux only.
MacOS is NOT tested.