fixed volume component

souporserious · Aug 5, 2015 · 5aa7ed9 · 5aa7ed9
1 parent be815eb
commit 5aa7ed9
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 5 deletions.
diff --git a/README.md b/README.md
@@ -5,7 +5,7 @@ React media container component to help build video & audio players.
 ## TODOS
 
 - [x] Fix Progress component
-- [] Fix Volume getting locked up when player is muted
+- [x] Fix Volume getting locked up when player is muted
 - [] Playlist feature
 - [] Show time preview when hovering scrubber
 - [] Show thumbnail preview when hovering scrubber

diff --git a/src/controls/Volume.jsx b/src/controls/Volume.jsx
@@ -5,8 +5,14 @@ class Volume {
   dragging = false
 
   _handleChange(e) {
-    const { player } = this.props;
-    player.volume = (+e.target.value).toFixed(4);
+
+    let { muted, volume } = this.props.player;
+
+    if(muted) {
+      muted = false;
+    }
+
+    volume = (+e.target.value).toFixed(4);
   }
 
   _handleDragging() {
@@ -15,11 +21,15 @@ class Volume {
 
   _handleDrag(e) {
 
-    const { player } = this.props;
+    let { muted, volume } = this.props.player;
 
     if(this.dragging) {
 
-      player.volume = (+e.target.value).toFixed(4);
+      if(muted) {
+        muted = false;
+      }
+
+      volume = (+e.target.value).toFixed(4);
 
       if(e.type === 'mouseup') {
         this.dragging = false;