-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SoundNft -> SoundEdition #6
Conversation
|
5212c2e
to
6eaa4ac
Compare
dd32bb4
to
5e0ec53
Compare
override | ||
returns (address fundingRecipient, uint256 royaltyAmount) | ||
{ | ||
// todo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added these functions because IERC2981Upgradeable inherits from IERC165Upgradeable, which I thought I might need for the registry, which wasn't the case.
However, both will be needed eventually so I figured it doesn't hurt to keep them.
@@ -59,7 +59,7 @@ contract SoundCreatorV1 { | |||
// todo: research if we can get any gas savings by using a more minimal version of Clones lib | |||
soundNft = Clones.clone(nftImplementation); | |||
|
|||
ISoundNftV1(soundNft).initialize(_name, _symbol); | |||
ISoundEditionV1(soundNft).initialize(msg.sender, _name, _symbol); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to pass in msg.sender to ensure it is set as the owner of the NFT. If we used msg.sender within SoundNftV1.sol, it would set SoundCreatorV1.sol as the owner. And if we used tx.origin, contracts wouldn't be able to create/own NFTs.
703d5ff
to
80f28bf
Compare
6cd8189
to
0216449
Compare
initialize
function