Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SoundNft -> SoundEdition #6

Merged
merged 4 commits into from
Jul 21, 2022
Merged

SoundNft -> SoundEdition #6

merged 4 commits into from
Jul 21, 2022

Conversation

gigamesh
Copy link
Contributor

@gigamesh gigamesh commented Jul 20, 2022

  • adds README
  • Renames SoundNFt to SoundEdition
  • Implements initialize function
  • Updates spec

@changeset-bot
Copy link

changeset-bot bot commented Jul 20, 2022

⚠️ No Changeset found

Latest commit: 0216449

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gigamesh gigamesh changed the title Implements initialize in SoundNftV1 SoundNft -> SoundEdition Jul 20, 2022
override
returns (address fundingRecipient, uint256 royaltyAmount)
{
// todo
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added these functions because IERC2981Upgradeable inherits from IERC165Upgradeable, which I thought I might need for the registry, which wasn't the case.

However, both will be needed eventually so I figured it doesn't hurt to keep them.

@@ -59,7 +59,7 @@ contract SoundCreatorV1 {
// todo: research if we can get any gas savings by using a more minimal version of Clones lib
soundNft = Clones.clone(nftImplementation);

ISoundNftV1(soundNft).initialize(_name, _symbol);
ISoundEditionV1(soundNft).initialize(msg.sender, _name, _symbol);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to pass in msg.sender to ensure it is set as the owner of the NFT. If we used msg.sender within SoundNftV1.sol, it would set SoundCreatorV1.sol as the owner. And if we used tx.origin, contracts wouldn't be able to create/own NFTs.

@github-actions
Copy link
Contributor

Fails
🚫 This PR does not contain a changeset. Please add one.

Generated by 🚫 dangerJS against 0216449

@gigamesh gigamesh merged commit febce3d into master Jul 21, 2022
@gigamesh gigamesh deleted the matt/SoundNftV1 branch July 21, 2022 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants