Support HMR by overriding store.replaceReducer()
#32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need time to test this. Thanks |
68ea9bf to
178d743
Compare
|
Added an example. Its just a slight variation of the basic one, so the two could probably be combined. |
|
Changed my mind about the example. The library doesn't really change how HMR is implemented, so I just used it to verify the fix and removed it. I'll merge once I've rebased. |
This was referenced Oct 15, 2017
Closed
|
Thanks for taking care of this and other PRs @wacii |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support Hot Module Replacement you need to enhance the reducer each time
store.replaceReducer()is called.see #31