Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the guard for max amount of serializers #46

Closed

Conversation

juanperi
Copy link
Contributor

@juanperi juanperi commented Jul 4, 2016

While reviewing #45, I just spotted that the guard is wrong, as allows up until 8 serializers.
At the same time, the test was wrong, as adding up until 10 serializers more doesn't ensure that we can have up to 7

@coveralls
Copy link

coveralls commented Jul 4, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 68709fd on epilgrim:fix/amount-of-serializers-guard into 553d452 on sorentwo:master.

@sorentwo
Copy link
Owner

sorentwo commented Jul 4, 2016

Thanks for catching these (and for helping with the rassoc fix in the other PR). Merged locally, closed with f336167.

@sorentwo sorentwo closed this Jul 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants