Skip to content

Commit

Permalink
Fix the guard for max amount of serializers
Browse files Browse the repository at this point in the history
  • Loading branch information
juanperi authored and sorentwo committed Jul 4, 2016
1 parent 4aaa51a commit d9caeb8
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion lib/readthis/serializers.rb
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ def <<(serializer)
case
when serializers.frozen?
raise SerializersFrozenError
when serializers.length > SERIALIZER_LIMIT
when serializers.length >= SERIALIZER_LIMIT
raise SerializersLimitError
else
@serializers[serializer] = flags.max.succ
Expand Down
4 changes: 2 additions & 2 deletions spec/readthis/serializers_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@

it 'prevents more than seven serializers' do
serializers = Readthis::Serializers.new

serializers << Class.new until serializers.flags.length >= 7
expect do
10.times { serializers << Class.new }
serializers << Class.new
end.to raise_error(Readthis::SerializersLimitError)
end
end
Expand Down

0 comments on commit d9caeb8

Please sign in to comment.