-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make build image linux/arm64 compatible #8
Conversation
👋 Hey there @jez - I'm not sure of the code of conduct in this repository with respect to pull requests & requesting reviews, but I'd just like the bring this PR to your attention. |
This is great, could we get a review @jez? |
… GLIBCXX_3.4.26' not found error
I've updated the PR to not upgrade the base image to Ubuntu 20.04, and instead installing a newer version of |
Great stuff! I'm curious when we can expect this to be merged to support aarch64 / arm64 natively? |
Friendly bump on this @froydnj |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @noizwaves !
Hey folks,
I've been exploring
sorbet-static
builds for the linux aarch64 platform, and part of that work has involved changes to thesorbet-build-image
so that anlinux/arm64
image can be built.In summary, the significant changes are:
libstdc++6
fromppa:ubuntu-toolchain-r/test
(to provideGLIBCXX_3.4.26
)bazel_loader/bazel
to install Bazel binaries on linux/aarch64 (installer scripts are not published for linux/aarch64 unfortunately)Testing
Testing involves running the
.buildkite/build-static-release.sh
from the sorbet repository. Unless specified otherwise, Sorbet version 0.5.11010 is the version of the gem being built.linux/amd64
This test was performed on an Intel 8700K computer running Ubuntu 20.04. See the attached file built_output_amd64.log for complete build output.
Additional characteristics of the
sorbet
binary:linux/arm64
This test was performed on an Apple MacBook Pro M1 running Docker Desktop 4.22 (file sharing:
gRPC FUSE
,Use Virtualization Framework
checked). See built_output_arm64.log for complete build output.A small modification is required to sorbet's
.bazel_rc
:small diff
Additional characteristics of the binary:
testing the static gem
The
arm64
gem (version 0.5.10983) built by the image successfully runs against Gusto's monolith: