Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: pin urllib3<2.3 to accommodate our old fork of vcrpy #2647

Merged
merged 2 commits into from
Jan 26, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions dev-requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ sphinx-rfcsection~=0.1.1
# use fork of vcrpy 5.x until kevin1024/vcrpy#777 is (hopefully) accepted
# (or until py3.9 EOL... in 10/2025, I HOPE NOT)
vcrpy @ git+https://github.com/sopel-irc/vcrpy@uncap-urllib3
# also have to use a version of urllib3 that doesn't use the `version_string`
# attr of the response object, because vcrpy won't support it until 7.x
urllib3<2.3
# type check
# often breaks CI on master, so pin and update deliberately, on our own terms
mypy==1.11.2
Expand Down
2 changes: 1 addition & 1 deletion sopel/tools/time.py
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ def validate_timezone(zone: Optional[str]) -> str:
except pytz.exceptions.UnknownTimeZoneError:
raise ValueError('Invalid time zone.')

return cast(str, tz.zone)
return cast('str', tz.zone)


def validate_format(tformat: str) -> str:
Expand Down
2 changes: 1 addition & 1 deletion sopel/trigger.py
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ def __init__(

# The regex will always match any string, even an empty one
components_match = cast(
Match, PreTrigger.component_regex.match(self.hostmask or ''))
'Match', PreTrigger.component_regex.match(self.hostmask or ''))
nick, self.user, self.host = components_match.groups()
self.nick: Identifier = self.make_identifier(nick)

Expand Down
Loading