Skip to content

Commit

Permalink
build: pin urllib3<2.3 to accommodate our old fork of vcrpy
Browse files Browse the repository at this point in the history
We can unpin this when py3.9 support drops in October 2025. Original
hope was to get a PR merged upstream in vcrpy that fixes the urllib
version issues with Python < 3.10, but that hasn't gone anywhere.
  • Loading branch information
dgw committed Jan 24, 2025
1 parent 7e3faa0 commit 31d9026
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions dev-requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ sphinx-rfcsection~=0.1.1
# use fork of vcrpy 5.x until kevin1024/vcrpy#777 is (hopefully) accepted
# (or until py3.9 EOL... in 10/2025, I HOPE NOT)
vcrpy @ git+https://github.com/sopel-irc/vcrpy@uncap-urllib3
# also have to use a version of urllib3 that doesn't use the `version_string`
# attr of the response object, because vcrpy won't support it until 7.x
urllib3<2.3
# type check
# often breaks CI on master, so pin and update deliberately, on our own terms
mypy==1.11.2
Expand Down

0 comments on commit 31d9026

Please sign in to comment.