Fix lgtm.com alert: cannot test value equality of Integers using '==' operator #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an alert reported by lgtm.com: value equality of boxed Integers cannot be tested using the '==' operator.
There are about 130 other alerts (https://lgtm.com/projects/g/Sable/soot/alerts/) - most of which really look like they're worth fixing. However, they need someone with more knowledge of the Soot codebase to decide what's the best way to fix.
If you like you can enable PR check integration: lgtm will automatically review your changes and flag up any new alerts that are introduced. Other projects are actively using it - here's an example from NASA's OpenMBEE project fixing a potential resource leak before merging the PR: Open-MBEE/exec-cameo-mdk#105
Details: https://lgtm.com/projects/g/Sable/soot/snapshot/dist-1791462132-1492508422322/files/src/soot/jimple/spark/solver/PropCycle.java#V106
Hope this is the right way to contribute - let me know if there's anything else I can do!