Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable TypeAssigner by default and explain BodyInterceptors #883

Merged
merged 9 commits into from
Feb 29, 2024

Conversation

swissiety
Copy link
Collaborator

@swissiety swissiety commented Feb 28, 2024

  • enable TypeAssigner
  • small refactorings
  • improve fault tolerance

closes #836

Copy link
Contributor

You updated the documentation - Doc Preview.

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 57.44681% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 69.84%. Comparing base (8c785af) to head (1edd316).
Report is 2 commits behind head on develop.

Files Patch % Lines
...tecode/interceptors/typeresolving/TypeChecker.java 0.00% 9 Missing and 6 partials ⚠️
...ecode/interceptors/typeresolving/TypeResolver.java 25.00% 2 Missing and 1 partial ⚠️
...otup/java/bytecode/interceptors/LocalSplitter.java 88.23% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #883      +/-   ##
=============================================
+ Coverage      68.54%   69.84%   +1.30%     
- Complexity      3890     4028     +138     
=============================================
  Files            311      311              
  Lines          15196    15212      +16     
  Branches        2588     2589       +1     
=============================================
+ Hits           10416    10625     +209     
+ Misses          3879     3735     -144     
+ Partials         901      852      -49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swissiety swissiety changed the title explain BodyInterceptors enable TypeAssigner by default and explain BodyInterceptors Feb 29, 2024
@swissiety swissiety requested a review from stschott February 29, 2024 09:53
Copy link
Collaborator

@JonasKlauke JonasKlauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

42 minutes? 😝

@JonasKlauke JonasKlauke merged commit eb7c095 into develop Feb 29, 2024
9 of 10 checks passed
@JonasKlauke JonasKlauke deleted the doc/Interceptors branch February 29, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants