Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

name the Local for the "this" reference: this #879

Merged
merged 3 commits into from
Feb 28, 2024

Conversation

swissiety
Copy link
Collaborator

@swissiety swissiety commented Feb 28, 2024

  • name "this" this
  • handle possible Local name collisions so that we can distinguish Locals that refer to different Locals/Memory

@swissiety swissiety force-pushed the fix/localname_collisions branch from b545dfa to 6ad5711 Compare February 28, 2024 16:07
@swissiety swissiety force-pushed the fix/localname_collisions branch from 6ad5711 to 76b8a7c Compare February 28, 2024 16:29
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.55%. Comparing base (348d3b2) to head (76b8a7c).
Report is 11 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #879      +/-   ##
=============================================
+ Coverage      68.28%   68.55%   +0.26%     
- Complexity      3881     3891      +10     
=============================================
  Files            311      311              
  Lines          15192    15196       +4     
  Branches        2588     2588              
=============================================
+ Hits           10374    10417      +43     
+ Misses          3909     3879      -30     
+ Partials         909      900       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swissiety swissiety changed the title fix more possible localname collisions and name this this this this Feb 28, 2024
@swissiety swissiety changed the title this this name the Local for the this reference: this Feb 28, 2024
@swissiety swissiety changed the title name the Local for the this reference: this name the Local for the "this" reference: this Feb 28, 2024
Copy link
Collaborator

@JonasKlauke JonasKlauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@JonasKlauke JonasKlauke merged commit 8c785af into develop Feb 28, 2024
9 checks passed
@JonasKlauke JonasKlauke deleted the fix/localname_collisions branch February 28, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants