Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method signature validator #860

Merged
merged 8 commits into from
Feb 22, 2024
Merged

Method signature validator #860

merged 8 commits into from
Feb 22, 2024

Conversation

akshitad11
Copy link
Collaborator

Method Signature Validator Changes

@swissiety
Copy link
Collaborator

hint: #863 targets the same Validator - but mostly checks for allowed return types

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b3fff66) 68.78% compared to head (8a0bec4) 68.86%.

Files Patch % Lines
...up/core/validation/MethodDeclarationValidator.java 96.87% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #860      +/-   ##
=============================================
+ Coverage      68.78%   68.86%   +0.08%     
- Complexity      3859     3882      +23     
=============================================
  Files            309      309              
  Lines          15222    15254      +32     
  Branches        2585     2601      +16     
=============================================
+ Hits           10470    10505      +35     
+ Misses          3866     3861       -5     
- Partials         886      888       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kadirayk kadirayk merged commit af48e89 into develop Feb 22, 2024
9 checks passed
@kadirayk kadirayk deleted the MethodSignatureValidator branch February 22, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants