CheckInitValidator changes #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #822 +/- ##
=============================================
+ Coverage 63.74% 63.79% +0.05%
- Complexity 3417 3425 +8
=============================================
Files 312 312
Lines 15086 15099 +13
Branches 2559 2563 +4
=============================================
+ Hits 9616 9633 +17
+ Misses 4557 4553 -4
Partials 913 913 ☔ View full report in Codecov by Sentry. |
kadirayk
requested changes
Jan 22, 2024
sootup.core/src/main/java/sootup/core/validation/CheckInitValidator.java
Outdated
Show resolved
Hide resolved
sootup.core/src/main/java/sootup/core/validation/CheckInitValidator.java
Outdated
Show resolved
Hide resolved
kadirayk
reviewed
Feb 1, 2024
| * l + " not definitely defined at " + s + " in " + body.getMethod(), false); } } } } | ||
| */ | ||
| return null; | ||
| List<ValidationException> validationException = new ArrayList<>(); |
There was a problem hiding this comment.
Thanks @akshitad11 ! Could you also add a few sentences to describe this?
# Conflicts: # sootup.core/src/main/java/sootup/core/validation/CheckInitValidator.java # sootup.tests/src/test/resources/validator/jimple/CheckInitValidator.jimple
kadirayk
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CheckInitValidator changes and Test cases