Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting CheckVoidLocalesValidator.java #809

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

akshitad11
Copy link
Collaborator

Local.java has a check present to not allow VoidType for local.

@akshitad11 akshitad11 requested a review from kadirayk January 10, 2024 17:40
# Conflicts:
#	sootup.core/src/main/java/sootup/core/validation/CheckVoidLocalesValidator.java
@kadirayk
Copy link
Member

@akshitad11 you probably need to merge the dev branch locally and commit again, it thinks there is a conflict.

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (570fd8b) 63.70% compared to head (4dbaabe) 63.70%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #809      +/-   ##
=============================================
- Coverage      63.70%   63.70%   -0.01%     
+ Complexity      3440     3439       -1     
=============================================
  Files            314      313       -1     
  Lines          15166    15163       -3     
  Branches        2568     2568              
=============================================
- Hits            9662     9660       -2     
+ Misses          4598     4597       -1     
  Partials         906      906              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akshitad11 akshitad11 merged commit cdd5e0a into develop Jan 11, 2024
8 checks passed
@akshitad11 akshitad11 deleted the CheckVoidLocalesValidator branch January 11, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants