FieldRef validator changes #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # sootup.core/src/main/java/sootup/core/validation/FieldRefValidator.java
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #791 +/- ##
=============================================
+ Coverage 63.38% 63.86% +0.47%
- Complexity 3376 3405 +29
=============================================
Files 314 314
Lines 15074 15097 +23
Branches 2557 2566 +9
=============================================
+ Hits 9555 9641 +86
+ Misses 4626 4549 -77
- Partials 893 907 +14 ☔ View full report in Codecov by Sentry. |
swissiety
previously approved these changes
Jan 4, 2024
Comment on lines
+71
to
+72
| validationException.add( | ||
| new ValidationException(fr, "Resolved field is null: " + fr.toString())); |
There was a problem hiding this comment.
this can occur when not a complete program is given in the input - lets just ignore those cases.
Comment on lines
+56
to
+57
| if (!fieldOpt.isPresent()) { | ||
| validationException.add(new ValidationException(v, "Resolved field is empty: ")); |
There was a problem hiding this comment.
this can occur when not a complete program is given in the input - lets just ignore those cases.
because I can. There are changes needed.
kadirayk
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FieldRef validator changes and test cases