Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New API: get method by name #777

Merged
merged 3 commits into from
Dec 18, 2023
Merged

Conversation

Liyw979
Copy link
Contributor

@Liyw979 Liyw979 commented Dec 17, 2023

No description provided.

Copy link

codecov bot commented Dec 17, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (647da14) 63.95% compared to head (25d2a54) 63.78%.
Report is 209 commits behind head on develop.

Files Patch % Lines
...src/main/java/sootup/core/model/AbstractClass.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #777      +/-   ##
=============================================
- Coverage      63.95%   63.78%   -0.18%     
+ Complexity      3424     3382      -42     
=============================================
  Files            317      315       -2     
  Lines          15391    15014     -377     
  Branches        2609     2534      -75     
=============================================
- Hits            9844     9577     -267     
+ Misses          4639     4544      -95     
+ Partials         908      893      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JonasKlauke
Copy link
Collaborator

mmh I think getMethodByName would be a better name otherwise you might think you can input a string of a method signature

Co-authored-by: Jonas Klauke <97177448+JonasKlauke@users.noreply.github.com>
@Liyw979
Copy link
Contributor Author

Liyw979 commented Dec 18, 2023

mmh I think getMethodByName would be a better name otherwise you might think you can input a string of a method signature

I think so.

Copy link
Collaborator

@JonasKlauke JonasKlauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JonasKlauke JonasKlauke merged commit ad962f4 into soot-oss:develop Dec 18, 2023
7 of 8 checks passed
@Liyw979 Liyw979 deleted the feat_getmethod branch February 28, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants