Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add getParameterCount for methodSignature #1131

Merged
merged 7 commits into from
Jan 6, 2025
Merged

add getParameterCount for methodSignature #1131

merged 7 commits into from
Jan 6, 2025

Conversation

Liyw979
Copy link
Contributor

@Liyw979 Liyw979 commented Nov 16, 2024

like getParameterCount of sootmethod

@swissiety
Copy link
Collaborator

please make SootMethod use the new method as well

@Liyw979
Copy link
Contributor Author

Liyw979 commented Nov 16, 2024 •
edited
Loading

@swissiety Done
It makes me wonder why do we do
this.parameterTypes = ImmutableUtils.immutableListOf(methodSignature.getParameterTypes()); in SootMethod
Can we remove this to make the code simpler?

@swissiety
Copy link
Collaborator

@swissiety Done It makes me wonder why do we do this.parameterTypes = ImmutableUtils.immutableListOf(methodSignature.getParameterTypes()); in SootMethod Can we remove this to make the code simpler?

yes, this makes sense!

@Liyw979
Copy link
Contributor Author

Liyw979 commented Jan 6, 2025 •
edited
Loading

SootMethod and MethodSignature now offer consistent APIs

@swissiety swissiety merged commit 88906ad into soot-oss:develop Jan 6, 2025
7 checks passed
@Liyw979 Liyw979 deleted the feat/parameter_count branch January 23, 2025 15:07
@Liyw979 Liyw979 restored the feat/parameter_count branch January 23, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swissiety swissiety swissiety approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Liyw979 @swissiety @stschott