Hotfix: Correct double serialization of tool call

soomo · Nov 23, 2024 · e73019b · e73019b
1 parent 15da3fb
commit e73019b
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/app/serializers/JsonSerializer.rb b/app/serializers/JsonSerializer.rb
@@ -36,4 +36,4 @@ def self.convert_value(value)
       value
     end
   end
-end
+end
diff --git a/app/services/ai_backend/tools.rb b/app/services/ai_backend/tools.rb
@@ -29,7 +29,7 @@ def get_tool_messages_by_calling(tool_calls_response)
         {
           role: "tool",
           content: function_response.to_json,
-          content_tool_calls: tool_call.to_json,
+          content_tool_calls: tool_call,
           tool_call_id: id,
         }
       end

diff --git a/test/services/ai_backend/open_ai_test.rb b/test/services/ai_backend/open_ai_test.rb
@@ -56,7 +56,7 @@ class AIBackend::OpenAITest < ActiveSupport::TestCase
       role: "tool",
       content: "\"Hello, World!\"",
       tool_call_id: "abc123",
-      content_tool_calls: messages(:weather_tool_call).content_tool_calls.first.to_json,
+      content_tool_calls: messages(:weather_tool_call).content_tool_calls.first,
     }
     assert_equal [tool_message], AIBackend::OpenAI.get_tool_messages_by_calling(messages(:weather_tool_call).content_tool_calls)
   end

diff --git a/test/services/ai_backend/tools_test.rb b/test/services/ai_backend/tools_test.rb
@@ -6,7 +6,7 @@ class AIBackend::ToolsTest < ActiveSupport::TestCase
       role: "tool",
       content: "\"Hello, World!\"",
       tool_call_id: "abc123",
-      content_tool_calls: messages(:weather_tool_call).content_tool_calls.first.to_json,
+      content_tool_calls: messages(:weather_tool_call).content_tool_calls.first,
     }
     assert_equal [tool_message], AIBackend.get_tool_messages_by_calling(messages(:weather_tool_call).content_tool_calls)
   end
@@ -19,7 +19,7 @@ class AIBackend::ToolsTest < ActiveSupport::TestCase
     msg = AIBackend::OpenAI.get_tool_messages_by_calling(tool_calls).first
     assert_equal "tool", msg[:role]
     assert_equal "abc123", msg[:tool_call_id]
-    assert_equal messages(:weather_tool_call).content_tool_calls.first.to_json, msg[:content_tool_calls]
+    assert_equal messages(:weather_tool_call).content_tool_calls.first, msg[:content_tool_calls]
     assert msg[:content].starts_with?('"An unexpected error occurred')
   end
 
@@ -31,7 +31,7 @@ class AIBackend::ToolsTest < ActiveSupport::TestCase
     msg = AIBackend::OpenAI.get_tool_messages_by_calling(tool_calls).first
     assert_equal "tool", msg[:role]
     assert_equal "abc123", msg[:tool_call_id]
-    assert_equal messages(:weather_tool_call).content_tool_calls.first.to_json, msg[:content_tool_calls]
+    assert_equal messages(:weather_tool_call).content_tool_calls.first, msg[:content_tool_calls]
     assert msg[:content].starts_with?('"An unexpected error occurred')
   end
 end
-Original file line number
+Diff line change
@@ Expand Up / @@ -36,4 +36,4 @@ def self.convert_value(value) @@
           value
         end
       end
-    end
+    end