Bring back stft test, and remove version limit of librosa #1195
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to resolve stft/istft test failures, skipped by #1193 .
Start from librosa 0.10.0, its stft implementation introduced some changes that may break existing testing cases of nnabla.
There seems to be an ongoing discussion on STFT inconsistencies regarding
tf.signal.stft
,torch.stft
,librosa.stft
andscipy.signal.stft
.But in this PR, we slightly changed one of our stft test parameter that could workaround the problem.
By the way, nnabla test case passes
window_type=rectangular
directly tolibrosa.stft
, but according to this document:And, refered to scipy document,
rectangular
should beboxcar
, so it's also changed in this PR.