Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix binary functions #114

Merged
merged 1 commit into from
Dec 3, 2018
Merged

Conversation

KazukiYoshiyama-sony
Copy link
Contributor

This breaks the backward compatibility but add the workaround.

  • Now we changed the behaviour of F.sign function when the input value is 0, it becomes 1 now.
  • Also, we add the argument to F.sign function and all binary functions which use F.sign as the workaround to control the behaviour when the input value is 0.

Change alpha_sign to quantize_zero_to.

Format.

Fix parameter name.
@StefanUhlich-sony StefanUhlich-sony merged commit d1e9474 into master Dec 3, 2018
@StefanUhlich-sony
Copy link
Contributor

@TE-KazukiYoshiyama Thanks for your work.

@StefanUhlich-sony StefanUhlich-sony deleted the fix/20181106_binary_functions branch December 3, 2018 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants