Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title: Implement Distributed Circuit Breaker (#70) #73

Merged
merged 26 commits into from
Dec 28, 2024

Conversation

YoshiyukiMineo
Copy link
Member

  • feature/redis-circuit-breaker

  • feature/redis-circuit-breaker

  • Refactor

  • save state

  • Saving half-open state also

  • Saving half-open state also

  • Added test case

  • Saving state transition

  • Pass context

  • Moved redis circuit breaker to v2

  • Revert go.mod and go.sum

  • Acked review comments

  • Refactor

  • Refactor


call-stack and others added 6 commits November 15, 2024 08:56
* feature/redis-circuit-breaker

* feature/redis-circuit-breaker

* Refactor

* save state

* Saving half-open state also

* Saving half-open state also

* Added test case

* Saving state transition

* Pass context

* Moved redis circuit breaker to v2

* Revert go.mod and go.sum

* Acked review comments

* Refactor

* Refactor

---------

Co-authored-by: Kalpit Pant <kalpit@setu.co>
@call-stack
Copy link
Contributor

call-stack commented Dec 5, 2024

Hi @YoshiyukiMineo , could you please let me know when this is expected to be merged into master? Let me know if there’s anything I can do to help move it forward. Thanks so much.

@YoshiyukiMineo
Copy link
Member Author

@call-stack

Thank you for your contribution.
Could you send a pull request to change from the current SharedStateStore to the following interface?

type SharedDataStore interface {
	GetData(ctx context.Context, name string) ([]byte, error)
	SetData(ctx context.Context, name string, data []byte) error
}

@call-stack
Copy link
Contributor

@YoshiyukiMineo I’ve implemented the necessary changes and updated the PR. Could you please review it at your convenience?
PR: #74

@YoshiyukiMineo YoshiyukiMineo merged commit f8351f6 into master Dec 28, 2024
8 checks passed
@YoshiyukiMineo YoshiyukiMineo deleted the distributed branch December 28, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants