Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SymbolStatisticsCache subscription without using a symbol #34

Closed
muskara opened this issue Jan 25, 2018 · 2 comments
Closed

SymbolStatisticsCache subscription without using a symbol #34

muskara opened this issue Jan 25, 2018 · 2 comments
Assignees
@sonvister
Labels
bug

Comments

@muskara
Copy link

muskara commented Jan 25, 2018

Binance/src/Binance/Cache/SymbolStatisticsCache.cs

Line 143 in 7ad8457

return new SymbolStatisticsCacheEventArgs(_symbols.Select(s => _statistics[s]).ToArray());

This is pointless when subscribe without using a symbol (!ticker@arr parameter)
@sonvister sonvister self-assigned this Jan 25, 2018
@sonvister sonvister added the bug label Jan 25, 2018
@sonvister
Copy link
Owner

Thanks 🤦‍♂️

sonvister added a commit that referenced this issue Feb 3, 2018
@sonvister
Do not rely on /wapi/v3/depositAddress.html response to contain 'asset'
60fa171 
Closes #34.
@sonvister
Copy link
Owner

I meant to close #46 with that commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sonvister sonvister

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sonvister @muskara