Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetSymbolsAsync fails #111

Closed
bobby-ko opened this issue Dec 4, 2018 · 3 comments
Closed

GetSymbolsAsync fails #111

bobby-ko opened this issue Dec 4, 2018 · 3 comments
Assignees

Comments

@bobby-ko
Copy link

bobby-ko commented Dec 4, 2018

GetExchangeInfoAsync is responding with a new JSON structure - more entries in the "filters" array. Method fails trying to get LOT_SIZE properties because its not at index 1 any more.

I've got a fix for this already, do you guys accept push requests?

@sonvister
Copy link
Owner

@bobby-coinstorm, thanks for mentioning this issue. I have been working on other changes so I started looking into this too. I would be interested in seeing your fix (btw, there are no "guys", it's just me).

So far I have found this to be significantly more than just changing indexes since they also broke the existing "PRICE_FILTER" by not including the actual values. I have a potential fix to keep the related validation working, but there are aspects that are probably unfinished or incorrect and certainly not to my liking. Regardless, there is probably no rush to release this since it has apparently been broken since 11-13....

@sonvister sonvister self-assigned this Dec 4, 2018
sonvister added a commit that referenced this issue Dec 5, 2018
For #111. Extend InclusiveRange (w/ PriceRange class) to transparently get symbol average price to calculate minimum and maximum price limits.
@bobby-ko
Copy link
Author

bobby-ko commented Dec 5, 2018

Thanks for the quick response on this. My "fix" is very to what you have - actually you seem to handle the case even better so I'm going to use that in my tests for now until the package update is out. So far so good, I'll let you know if I find any issues.

sonvister added a commit that referenced this issue Dec 5, 2018
@sonvister
Copy link
Owner

@bobby-coinstorm, let me know if you find any issues with 0.2.0-beta9. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants