-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem with NewBinanceWApiException #108
Comments
@khoofard, I'm glad you enjoy working with the code and thanks for this information. I'll make the following change: if (!string.IsNullOrWhiteSpace(error))
{
if (error.IsJsonObject())
{
try // to parse server error response.
{
var jError = JObject.Parse(error);
errorCode = jError["code"]?.Value<int>() ?? 0;
errorMessage = jError["msg"]?.Value<string>();
}
catch (Exception e)
{
_logger?.LogError(e, $"{nameof(BinanceApi)}.{methodName} failed to parse server error response: \"{error}\"");
throw;
}
}
else
{
errorMessage = error;
}
} |
sonvister
added a commit
that referenced
this issue
Nov 28, 2018
Test results using
This change will be in 0.2.0-beta9... but, I think I'll wait a bit before creating that release. |
Thank you for such a quick response. What is the best way to contact you? Here? Email? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I tried a withdrawal using API Keys that did not have withdrawal permissions. The exception being returned from this method does not include the "You don't have permission." message in the JSON variable. So unless I debugged it, I could not tell why my withdrawal failed.
Here is a screen shot from debugging that shows the key fields in the immediate window.
Absolutely love this code! Thank you so much!
The text was updated successfully, but these errors were encountered: