Require semicolon for function declaration with no body (palantir#1447)

soniro · Aug 31, 2016 · f585cbc · f585cbc
1 parent ded0407
commit f585cbc
Show file tree

Hide file tree

Showing 9 changed files with 80 additions and 0 deletions.
diff --git a/src/rules/semicolonRule.ts b/src/rules/semicolonRule.ts
@@ -140,6 +140,13 @@ class SemicolonWalker extends Lint.RuleWalker {
         super.visitExportAssignment(node);
     }
 
+    public visitFunctionDeclaration(node: ts.FunctionDeclaration) {
+        if (!node.body) {
+            this.checkSemicolonAt(node);
+        }
+        super.visitFunctionDeclaration(node);
+    }
+
     private checkSemicolonAt(node: ts.Node) {
         const sourceFile = this.getSourceFile();
         const children = node.getChildren(sourceFile);

diff --git a/test/rules/semicolon/always/test.ts.fix b/test/rules/semicolon/always/test.ts.fix
@@ -30,6 +30,14 @@ debugger;
 import v = require("i");
 module M {
     export var x;
+    export function f(s: string): string;
+    export function f(n: number): number;
+    export function f(x: any) { return x; }
+}
+
+declare module "M" {
+    function f(): number;
+    function g(): number;
 }
 
 function useStrictMissingSemicolon() {

diff --git a/test/rules/semicolon/always/test.ts.lint b/test/rules/semicolon/always/test.ts.lint
@@ -44,6 +44,16 @@ import v = require("i")
 module M {
     export var x
                 ~nil [Missing semicolon]
+    export function f(s: string): string;
+    export function f(n: number): number
+                                        ~nil [Missing semicolon]
+    export function f(x: any) { return x; }
+}
+
+declare module "M" {
+    function f(): number;
+    function g(): number
+                        ~nil [Missing semicolon]
 }
 
 function useStrictMissingSemicolon() {

diff --git a/test/rules/semicolon/enabled/test.ts.fix b/test/rules/semicolon/enabled/test.ts.fix
@@ -30,6 +30,14 @@ debugger;
 import v = require("i");
 module M {
     export var x;
+    export function f(s: string): string;
+    export function f(n: number): number;
+    export function f(x: any) { return x; }
+}
+
+declare module "M" {
+    function f(): number;
+    function g(): number;
 }
 
 function useStrictMissingSemicolon() {

diff --git a/test/rules/semicolon/enabled/test.ts.lint b/test/rules/semicolon/enabled/test.ts.lint
@@ -44,6 +44,16 @@ import v = require("i")
 module M {
     export var x
                 ~nil [Missing semicolon]
+    export function f(s: string): string;
+    export function f(n: number): number
+                                        ~nil [Missing semicolon]
+    export function f(x: any) { return x; }
+}
+
+declare module "M" {
+    function f(): number;
+    function g(): number
+                        ~nil [Missing semicolon]
 }
 
 function useStrictMissingSemicolon() {

diff --git a/test/rules/semicolon/ignore-interfaces/test.ts.fix b/test/rules/semicolon/ignore-interfaces/test.ts.fix
@@ -30,6 +30,14 @@ debugger;
 import v = require("i");
 module M {
     export var x;
+    export function f(s: string): string;
+    export function f(n: number): number;
+    export function f(x: any) { return x; }
+}
+
+declare module "M" {
+    function f(): number;
+    function g(): number;
 }
 
 function useStrictMissingSemicolon() {

diff --git a/test/rules/semicolon/ignore-interfaces/test.ts.lint b/test/rules/semicolon/ignore-interfaces/test.ts.lint
@@ -44,6 +44,16 @@ import v = require("i")
 module M {
     export var x
                 ~nil [Missing semicolon]
+    export function f(s: string): string;
+    export function f(n: number): number
+                                        ~nil [Missing semicolon]
+    export function f(x: any) { return x; }
+}
+
+declare module "M" {
+    function f(): number;
+    function g(): number
+                        ~nil [Missing semicolon]
 }
 
 function useStrictMissingSemicolon() {

diff --git a/test/rules/semicolon/never/test.ts.fix b/test/rules/semicolon/never/test.ts.fix
@@ -30,6 +30,14 @@ debugger
 import v = require("i")
 module M {
     export var x
+    export function f(s: string): string
+    export function f(n: number): number
+    export function f(x: any) { return x }
+}
+
+declare module "M" {
+    function f(): number
+    function g(): number
 }
 
 function useStrictUnnecessarySemicolon() {

diff --git a/test/rules/semicolon/never/test.ts.lint b/test/rules/semicolon/never/test.ts.lint
@@ -44,6 +44,17 @@ import v = require("i");
 module M {
     export var x;
                 ~ [Unnecessary semicolon]
+    export function f(s: string): string;
+                                        ~ [Unnecessary semicolon]
+    export function f(n: number): number
+    export function f(x: any) { return x; }
+                                        ~ [Unnecessary semicolon]
+}
+
+declare module "M" {
+    function f(): number;
+                        ~ [Unnecessary semicolon]
+    function g(): number
 }
 
 function useStrictUnnecessarySemicolon() {