Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fdbshow][nbrshow] Print interface OID in lieu of name if there is no OID->interface name mapping #789

Merged
merged 1 commit into from
Jan 24, 2020

Conversation

jleveque
Copy link
Contributor

In release branches prior to 201911, FDB or ARP learnt on VLAN interface LAG port will cause nothing to appear in the "show arp" or "show mac" output because there existed no OID->interface name never had the mappings for LAG interface.

This issue has since been fixed in master (and 201911). However, making this change in master is not harmful and will prevent a regression from causing no output to be displayed for the interface name in the future.

@lguohan
Copy link
Contributor

lguohan commented Jan 24, 2020

retest this please

@lguohan lguohan merged commit 377881d into sonic-net:master Jan 24, 2020
@jleveque jleveque deleted the pc_oid_as_name branch January 24, 2020 23:17
yxieca pushed a commit that referenced this pull request Jan 25, 2020
… OID->interface name mapping (#789)

In release branches prior to 201911, FDB or ARP learnt on VLAN interface LAG port will cause nothing to appear in the "show arp" or "show mac" output because there existed no OID->interface name never had the mappings for LAG interface.

This issue has since been fixed in master (and 201911). However, making this change in master is not harmful and will prevent a regression from causing no output to be displayed for the interface name in the future.
abdosi pushed a commit that referenced this pull request Feb 4, 2020
… OID->interface name mapping (#789)

In release branches prior to 201911, FDB or ARP learnt on VLAN interface LAG port will cause nothing to appear in the "show arp" or "show mac" output because there existed no OID->interface name never had the mappings for LAG interface.

This issue has since been fixed in master (and 201911). However, making this change in master is not harmful and will prevent a regression from causing no output to be displayed for the interface name in the future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants