[intfstat] fix --delete-all fail when counters dump does not exist #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>
liat-grozovik
approved these changes
Nov 24, 2019
|
retest this please |
2 similar comments
|
retest this please |
|
retest this please |
abdosi
pushed a commit
that referenced
this pull request
Jan 3, 2020
Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mykola Faryma mykolaf@mellanox.com
Fixes #749
- What I did
Additional check for counter snapshot folder existance.
- How I did it
- How to verify it
- Previous command output (if the output of a command-line utility has changed)
Traceback (most recent call last):
File "/usr/bin/intfstat", line 346, in
main()
File "/usr/bin/intfstat", line 272, in main
for file in os.listdir(cnstat_dir):
OSError: [Errno 2] No such file or directory: '/tmp/intfstat-0'
- New command output (if the output of a command-line utility has changed)