-
Notifications
You must be signed in to change notification settings - Fork 684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[config]: Add hostname command to config CLI #669
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sangita Maity <sangitamaity0211@gmail.com>
prsunny
reviewed
Sep 25, 2019
Signed-off-by: Sangita Maity <sangitamaity0211@gmail.com>
jleveque
reviewed
Sep 25, 2019
jleveque
suggested changes
Sep 25, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please simplify the command syntax from config change-hostname <new_hostname>
to config hostname <new_hostname>
Signed-off-by: Sangita Maity <sangitamaity0211@gmail.com>
jleveque
suggested changes
Sep 25, 2019
Signed-off-by: Sangita Maity <sangitamaity0211@gmail.com>
jleveque
approved these changes
Sep 25, 2019
Retest this please |
prsunny
approved these changes
Sep 27, 2019
Retest this please |
jleveque
suggested changes
Sep 27, 2019
Signed-off-by: Sangita Maity <sangitamaity0211@gmail.com>
jleveque
approved these changes
Sep 27, 2019
prsunny
reviewed
Sep 27, 2019
Retest this please |
2 similar comments
Retest this please |
Retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sangita Maity sangitamaity0211@gmail.com
- What I did
added new command change-hostname to config CLI so that the user can change the hostname on a SONiC device without traffic being impacted.
- How I did it
update "hostname" key to the "DEVICE_METADATA|localhost" field in config DB using sonic-cfggen and restart the hostname-config service.
- How to verify it
changed the hostname from csw06 to csw06-sonic