New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a command to update log level and refresh configuration #3428

Merged

prgeor merged 4 commits into sonic-net:master from Junchao-Mellanox:master-log

Oct 12, 2024

Collaborator

Junchao-Mellanox commented Jul 18, 2024

What I did

Add a command "config syslog level" to set log level at runtime.

How I did it

Add a command "config syslog level" to set log level at runtime. This command shall update log level in CONFIG DB and send SIGHUP to relevant daemon if it requires a manual refresh

How to verify it

manual test
new unit test case

Previous command output (if the output of a command-line utility has changed)

N/A

New command output (if the output of a command-line utility has changed)

root@sonic:/home/admin# config syslog level --help
Usage: config syslog level [OPTIONS]

  Configure log level

Options:
  -c, --component TEXT            Component name in DB for which loglevel is
                                  applied (provided with -l)  [required]
  -l, --level [DEBUG|INFO|NOTICE|WARN|ERROR]
                                  Loglevel value  [required]
  --service TEXT                  Container name to which the SIGHUP is sent
                                  (provided with --pid or --program)
  --program TEXT                  Program name to which the SIGHUP is sent
                                  (provided with --service)
  --pid TEXT                      Process ID to which the SIGHUP is sent
                                  (provided with --service if PID is from
                                  container)
  -?, -h, --help                  Show this message and exit.

Junchao-Mellanox requested a review from keboliu

July 18, 2024 02:59

Junchao-Mellanox marked this pull request as draft

July 18, 2024 02:59

Junchao-Mellanox mentioned this pull request

Python logger enhancement to support setting log level at real time sonic-net/SONiC#1522

Merged

Junchao-Mellanox force-pushed the master-log branch 3 times, most recently from 8698c9b to 3fb0263 Compare

July 18, 2024 03:44

Junchao-Mellanox requested a review from prgeor

July 18, 2024 03:45

Junchao-Mellanox marked this pull request as ready for review

July 18, 2024 03:45

Junchao-Mellanox force-pushed the master-log branch from 3fb0263 to f58bff8 Compare

July 19, 2024 02:10

Collaborator Author

Junchao-Mellanox commented Jul 19, 2024

/azpw run Azure.sonic-utilities

Collaborator

mssonicbld commented Jul 19, 2024

/AzurePipelines run Azure.sonic-utilities

azure-pipelines bot commented Jul 19, 2024

Azure Pipelines successfully started running 1 pipeline(s).

Junchao-Mellanox force-pushed the master-log branch 2 times, most recently from baa004d to d633c46 Compare

July 19, 2024 08:44


          Add a command to update log level and refresh configuration

cb72134

Junchao-Mellanox force-pushed the master-log branch from d633c46 to cb72134 Compare

July 22, 2024 01:34

prgeor reviewed

View reviewed changes

config/syslog.py Outdated Show resolved Hide resolved

Collaborator Author

Junchao-Mellanox commented Aug 5, 2024

Hi @prgeor , kindly reminder

Junchao-Mellanox added 2 commits

August 6, 2024 09:26


          Multi ASIC support

02c77e4


          Fix pre-commit issue

c5fe574

Contributor

xincunli-sonic commented Aug 9, 2024

Hi @Junchao-Mellanox, as debug purpose, do you want to add it into show cli?

Collaborator Author

Junchao-Mellanox commented Aug 12, 2024

Hi @Junchao-Mellanox, as debug purpose, do you want to add it into show cli?

There is an existing command swssloglevel -p which can be used to print the configured log level.

keboliu approved these changes

View reviewed changes

prgeor reviewed

View reviewed changes

doc/Command-Reference.md Outdated Show resolved Hide resolved

Collaborator

liat-grozovik commented Sep 3, 2024

@prgeor can you please help to review comment feedback ?

prgeor reviewed

View reviewed changes

doc/Command-Reference.md Outdated Show resolved Hide resolved

prgeor reviewed

View reviewed changes

config/syslog.py

+                      return
+                  log_config = cfg_db.get_entry('LOGGER', identifier)
+                  require_manual_refresh = log_config.get('require_manual_refresh')

Contributor

prgeor Sep 25, 2024 •

edited

Loading

@Junchao-Mellanox Who add this configuration to config DB and when?

Collaborator Author

Junchao-Mellanox Sep 26, 2024

Python logger will add this to config DB in init function. Check this PR https://github.com/sonic-net/sonic-buildimage/pull/19611/files line 62

linux-foundation-easycla bot commented Sep 27, 2024 •

edited

Loading

The committers listed above are authorized under a signed CLA.

✅ login: Junchao-Mellanox (cb72134, c5fe574, 02c77e4, 1b6aac7)


          Fix comment

1b6aac7

Fix review comment

Junchao-Mellanox force-pushed the master-log branch from d670aec to 1b6aac7 Compare

September 27, 2024 02:02

prgeor approved these changes

View reviewed changes

prgeor merged commit 88ef85c into sonic-net:master

7 checks passed

bradh352 added a commit to bradh352/sonic-buildimage that referenced this pull request


          [yang] LOGGER missing require_manual_refresh

8a8fd42

As of sonic-net#19611
and sonic-net/sonic-utilities#3428
a new database field of `require_manual_refresh` was added.

This leads to YANG failures in the factory-default configuration
for the `xcvrd` log entry which by default is written as true.

Signed-off-by: Brad House (@bradh352)

bradh352 mentioned this pull request

[yang] LOGGER missing require_manual_refresh sonic-net/sonic-buildimage#20969

Merged

9 tasks

bradh352 added a commit to bradh352/sonic-buildimage that referenced this pull request


          [yang] LOGGER missing require_manual_refresh

60e67ff

As of sonic-net#19611
and sonic-net/sonic-utilities#3428
a new database field of `require_manual_refresh` was added.

This leads to YANG failures in the factory-default configuration
for the `xcvrd` log entry which by default is written as true.

Signed-off-by: Brad House (@bradh352)

bradh352 added a commit to bradh352/sonic-buildimage that referenced this pull request


          [yang] LOGGER missing require_manual_refresh

f034a4a

As of sonic-net#19611
and sonic-net/sonic-utilities#3428
a new database field of `require_manual_refresh` was added.

This leads to YANG failures in the factory-default configuration
for the `xcvrd` log entry which by default is written as true.

Signed-off-by: Brad House (@bradh352)

github-actions bot pushed a commit to bradh352/sonic-buildimage that referenced this pull request


          [yang] LOGGER missing require_manual_refresh

5d762e5

As of sonic-net#19611
and sonic-net/sonic-utilities#3428
a new database field of `require_manual_refresh` was added.

This leads to YANG failures in the factory-default configuration
for the `xcvrd` log entry which by default is written as true.

Signed-off-by: Brad House (@bradh352)

bradh352 added a commit to bradh352/sonic-buildimage that referenced this pull request


          [yang] LOGGER missing require_manual_refresh

5264c4c

As of sonic-net#19611
and sonic-net/sonic-utilities#3428
a new database field of `require_manual_refresh` was added.

This leads to YANG failures in the factory-default configuration
for the `xcvrd` log entry which by default is written as true.

Signed-off-by: Brad House (@bradh352)

github-actions bot pushed a commit to bradh352/sonic-buildimage that referenced this pull request


          [yang] LOGGER missing require_manual_refresh

c5339f6

As of sonic-net#19611
and sonic-net/sonic-utilities#3428
a new database field of `require_manual_refresh` was added.

This leads to YANG failures in the factory-default configuration
for the `xcvrd` log entry which by default is written as true.

Signed-off-by: Brad House (@bradh352)

github-actions bot pushed a commit to bradh352/sonic-buildimage that referenced this pull request


          [yang] LOGGER missing require_manual_refresh

bda04fd

As of sonic-net#19611
and sonic-net/sonic-utilities#3428
a new database field of `require_manual_refresh` was added.

This leads to YANG failures in the factory-default configuration
for the `xcvrd` log entry which by default is written as true.

Signed-off-by: Brad House (@bradh352)

github-actions bot pushed a commit to bradh352/sonic-buildimage that referenced this pull request


          [yang] LOGGER missing require_manual_refresh

b61ce08

As of sonic-net#19611
and sonic-net/sonic-utilities#3428
a new database field of `require_manual_refresh` was added.

This leads to YANG failures in the factory-default configuration
for the `xcvrd` log entry which by default is written as true.

Signed-off-by: Brad House (@bradh352)

github-actions bot pushed a commit to bradh352/sonic-buildimage that referenced this pull request


          [yang] LOGGER missing require_manual_refresh

79a6f1e

As of sonic-net#19611
and sonic-net/sonic-utilities#3428
a new database field of `require_manual_refresh` was added.

This leads to YANG failures in the factory-default configuration
for the `xcvrd` log entry which by default is written as true.

Signed-off-by: Brad House (@bradh352)

github-actions bot pushed a commit to bradh352/sonic-buildimage that referenced this pull request


          [yang] LOGGER missing require_manual_refresh

b645b90

As of sonic-net#19611
and sonic-net/sonic-utilities#3428
a new database field of `require_manual_refresh` was added.

This leads to YANG failures in the factory-default configuration
for the `xcvrd` log entry which by default is written as true.

Signed-off-by: Brad House (@bradh352)

github-actions bot pushed a commit to bradh352/sonic-buildimage that referenced this pull request


          [yang] LOGGER missing require_manual_refresh

910ce6e

As of sonic-net#19611
and sonic-net/sonic-utilities#3428
a new database field of `require_manual_refresh` was added.

This leads to YANG failures in the factory-default configuration
for the `xcvrd` log entry which by default is written as true.

Signed-off-by: Brad House (@bradh352)

StormLiangMS pushed a commit to sonic-net/sonic-buildimage that referenced this pull request


          [yang] LOGGER missing require_manual_refresh (#20969)

9293b8c

Why I did it
YANG failures during config replace with default configuration.

As of #19611 and sonic-net/sonic-utilities#3428 a new database field of require_manual_refresh was added.

This leads to YANG failures in the factory-default configuration for the xcvrd log entry which by default is written as true.

Work item tracking
How I did it
Updated YANG file for new field.

How to verify it
Verify config replace works with factory default configuration.

VladimirKuk pushed a commit to Marvell-switching/sonic-buildimage that referenced this pull request


          [yang] LOGGER missing require_manual_refresh (sonic-net#20969)

52609e7

Why I did it
YANG failures during config replace with default configuration.

As of sonic-net#19611 and sonic-net/sonic-utilities#3428 a new database field of require_manual_refresh was added.

This leads to YANG failures in the factory-default configuration for the xcvrd log entry which by default is written as true.

Work item tracking
How I did it
Updated YANG file for new field.

How to verify it
Verify config replace works with factory default configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet