[SPM] Add logic to disable the feature before stopping it and enabling it before starting #3344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it before starting.
stepanblyschak
approved these changes
May 29, 2024
|
@lguohan can you suggest a reviewer for this issue? |
|
@lguohan kindly reminder the fix should go for both 202311 and 202405 |
|
@qiluo-msft could you please help to review? |
|
@qiluo-msft kindly reminder. do you want to assign someone else ? we need this to get in soon please |
qiluo-msft
reviewed
Sep 21, 2024
| @@ -1017,8 +1017,10 @@ def _get_installed_packages_except(self, package: Package) -> Dict[str, Package] | |||
|
|
|||
| def _stop_feature(self, package: Package): | |||
| self._systemctl_action(package, 'stop') | |||
| self._systemctl_action(package, 'disable') | |||
There was a problem hiding this comment.
@qiluo-msft UT added
qiluo-msft
previously approved these changes
Oct 26, 2024
|
/Azpw run |
|
/azpw run |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
approved these changes
Nov 11, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-utilities
that referenced
this pull request
Nov 15, 2024
…g it before starting (sonic-net#3344) What I did Add logic to disable the feature before stopping and enabling it before starting in order to properly clean the systemd symlinks to avoid issues with delayed attribute explained in the How to verify it section. How I did it Add the systemctl disable ... after the systemctl stop... and the systemctl enable ... before the systemctl start .. for some feature. How to verify it Add repository for some featureX sonic-package-manager repository <featureX> <URL> Install featureX version 1.0.0 where the delayed flag is equal to false (delayed flag means - the feature will be started right after the system boots or after the PortInitDone event) sonic-package-manager install featureX==1.0.0 -y Enable the feature in SONiC config feature state featureX enabled Install featureX version 1.0.1 where the delayed flag is equal to true sonic-package-manager install featureX==1.0.1 -y Check the manifest file to verify the delayed field value sonic-package-manager show package manifest featureX config save -y reboot Check that the featureX is delayed on the system start
|
Cherry-pick PR to 202405: #3619 |
mssonicbld
pushed a commit
that referenced
this pull request
Nov 15, 2024
…g it before starting (#3344) What I did Add logic to disable the feature before stopping and enabling it before starting in order to properly clean the systemd symlinks to avoid issues with delayed attribute explained in the How to verify it section. How I did it Add the systemctl disable ... after the systemctl stop... and the systemctl enable ... before the systemctl start .. for some feature. How to verify it Add repository for some featureX sonic-package-manager repository <featureX> <URL> Install featureX version 1.0.0 where the delayed flag is equal to false (delayed flag means - the feature will be started right after the system boots or after the PortInitDone event) sonic-package-manager install featureX==1.0.0 -y Enable the feature in SONiC config feature state featureX enabled Install featureX version 1.0.1 where the delayed flag is equal to true sonic-package-manager install featureX==1.0.1 -y Check the manifest file to verify the delayed field value sonic-package-manager show package manifest featureX config save -y reboot Check that the featureX is delayed on the system start
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Add logic to disable the feature before stopping and enabling it before starting in order to properly clean the
systemdsymlinks to avoid issues withdelayedattribute explained in theHow to verify itsection.How I did it
Add the
systemctl disable ...after thesystemctl stop...and thesystemctl enable ...before thesystemctl start ..for some feature.How to verify it
featureXsonic-package-manager repository <featureX> <URL>featureXversion 1.0.0 where thedelayedflag is equal tofalse(delayedflag means - the feature will be started right after the system boots or after thePortInitDoneevent)sonic-package-manager install featureX==1.0.0 -yconfig feature state featureX enabledfeatureXversion 1.0.1 where thedelayedflag is equal totruesonic-package-manager install featureX==1.0.1 -ymanifestfile to verify thedelayedfield valuesonic-package-manager show package manifest featureXconfig save -yrebootfeatureXis delayed on the system startPrevious command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)