Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display target firmware version through CLI #3274

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

mihirpat1
Copy link
Contributor

@mihirpat1 mihirpat1 commented Apr 18, 2024

What I did

XCVRD is now periodically storing target firmware versions in TRANSCEIVR_FIRMWARE_INFO table of STATE_DB (sonic-net/sonic-platform-common#455).
This change is to display the target firmware versions using show interfaces transceiver eeprom EthernetXX and show interfaces transceiver info EthernetXX CLI.

MSFT ADO - 27706023

How I did it

The transceiver EEPROM/INFO dump CLI now reads target firmware information from the TRANSCEIVR_FIRMWARE_INFO table of STATE_DB. This is done only for the transceivers which have their target firmware version information populated in the TRANSCEIVR_FIRMWARE_INFO table.

How to verify it

Please refer to the testcases described in sonic-net/sonic-platform-common#455 for further details.

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

snippet of show interfaces transceiver info EthernetXX CLI

Snippet of CLI o/p for transceiver supporting remote target (Other fields have been trimmed)

        Connector: No separable connector
        E1 Active Firmware: 4.1.2
        E1 Inactive Firmware: 2.5.0
        E1 Server Firmware: 1.3.0.3
        E2 Active Firmware: 4.1.2
        E2 Inactive Firmware: 2.5.0
        E2 Server Firmware: 1.3.0.3
        Encoding: N/A

CLI o/p for transceiver not supporting remote target

root@sonic:/home/admin# show interface transceiver info $lport
Ethernet128: SFP EEPROM detected
        Active Firmware: 5.4.0
        Active application selected code assigned to host lane 1: 1
        Active application selected code assigned to host lane 2: 1
        Active application selected code assigned to host lane 3: 1
        Active application selected code assigned to host lane 4: 1
        Active application selected code assigned to host lane 5: 1
        Active application selected code assigned to host lane 6: 1
        Active application selected code assigned to host lane 7: 1
        Active application selected code assigned to host lane 8: 1
        Application Advertisement: 400GAUI-4-L C2M (Annex 120G) - Host Assign (0x11) - 400GBASE-DR4 (Cl 124) - Media Assign (0x11)
                                   400GAUI-4-S C2M (Annex 120G) - Host Assign (0x11) - 400GBASE-DR4 (Cl 124) - Media Assign (0x11)
                                   100GAUI-1-L C2M (Annex 120G) - Host Assign (0xff) - 100GBASE-DR (Cl 140) - Media Assign (0xff)
                                   100GAUI-1-S C2M (Annex 120G) - Host Assign (0xff) - 100GBASE-DR (Cl 140) - Media Assign (0xff)
        CMIS Rev: 5.0
        Connector: MPO 1x16
        Encoding: N/A
        Extended Identifier: Power Class 8 (17.0W Max)
        Extended RateSelect Compliance: N/A
        Host Lane Count: 4
        Identifier: QSFP-DD Double Density 8X Pluggable Transceiver
        Inactive Firmware: 5.3.0
        Length Cable Assembly(m): 0.0
        Media Interface Technology: 1310 nm EML
        Media Lane Count: 4
        Module Hardware Rev: 1.0
        Nominal Bit Rate(100Mbs): 0
        Specification compliance: sm_media_interface
        Supported Max Laser Frequency: N/A
        Supported Max TX Power: N/A
        Supported Min Laser Frequency: N/A
        Supported Min TX Power: N/A
        Vendor Date Code(YYYY-MM-DD Lot): 2000-11-11 00
        Vendor Name: ABC
        Vendor OUI: 11-22-33
        Vendor PN: ABCDEFG
        Vendor Rev: A0
        Vendor SN: A11111         
root@sonic:/home/admin#

Signed-off-by: Mihir Patel <patelmi@microsoft.com>
@prgeor
Copy link
Contributor

prgeor commented Apr 23, 2024

@mihirpat1 can you also paste the output for cables that does not support remote target

@mihirpat1
Copy link
Contributor Author

@mihirpat1 can you also paste the output for cables that does not support remote target

@prgeor I have added the output now.

@prgeor prgeor merged commit df94636 into sonic-net:master Apr 25, 2024
5 checks passed
@mihirpat1
Copy link
Contributor Author

@StormLiangMS @yxieca Can you please help in merging this to 202305 and 202311?
MSFT ADO - 27706023

@yxieca
Copy link
Contributor

yxieca commented Apr 26, 2024

@StormLiangMS @yxieca Can you please help in merging this to 202305 and 202311? MSFT ADO - 27706023

@mihirpat1 this seems to be an enhancement? Is it fixing any outstanding known issue?

@mihirpat1
Copy link
Contributor Author

@StormLiangMS @yxieca Can you please help in merging this to 202305 and 202311? MSFT ADO - 27706023

@mihirpat1 this seems to be an enhancement? Is it fixing any outstanding known issue?

@yxieca Will follow-up on Teams.

@mihirpat1
Copy link
Contributor Author

@StormLiangMS @yxieca Can you please help in merging this to 202305 and 202311? MSFT ADO - 27706023

@mihirpat1 this seems to be an enhancement? Is it fixing any outstanding known issue?

@yxieca Will follow-up on Teams.

@yxieca This is needed to dump the the FW version of the remote sides for cables support FW upgrade on target from local side.

mssonicbld pushed a commit to mssonicbld/sonic-utilities that referenced this pull request Apr 30, 2024
Signed-off-by: Mihir Patel <patelmi@microsoft.com>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202311: #3298

mssonicbld pushed a commit that referenced this pull request Apr 30, 2024
Signed-off-by: Mihir Patel <patelmi@microsoft.com>
mssonicbld pushed a commit to mssonicbld/sonic-utilities that referenced this pull request May 4, 2024
Signed-off-by: Mihir Patel <patelmi@microsoft.com>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202305: #3307

mssonicbld pushed a commit that referenced this pull request May 4, 2024
Signed-off-by: Mihir Patel <patelmi@microsoft.com>
arfeigin pushed a commit to arfeigin/sonic-utilities that referenced this pull request Jun 16, 2024
Signed-off-by: Mihir Patel <patelmi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants