Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[202205][generate_dump] Revert "Revert generate_dump optimization PR's #2581", add fixes for empty /dump forder and symbolic links #2711

Merged

Conversation

vadymhlushko-mlnx
Copy link
Contributor

What I did

  1. Revert [202205] Revert the show-techsupport optimization PR's #2581
  2. Add a fix for the empty /dump folder inside the final tar archive generated by the show techsupport CLI command.
  3. Add a fix to not follow the symbolic links to avoid duplicate files inside the final tar archive generated by the show techsupport CLI command.

How I did it

Modify the scripts/generate_dump script.

How to verify it

  1. Manual verification
  • do the show techsupport CLI command and save output original.tar.gz (with original generate_dump script)
  • do the show techsupport CLI command and save output fixes.tar.gz (with the generate_dump script modified by this PR)
  • unpack both archives original.tar.gz and fixes.tar.gz
  • compare both directories with ncdu & diff --brief --recursive original fixes Linux utilities
  1. Run the community tests

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

@vadymhlushko-mlnx vadymhlushko-mlnx force-pushed the 202205-generate-dump-optimization-2 branch 2 times, most recently from 589f3eb to f087b8a Compare March 6, 2023 12:21
Signed-off-by: vadymhlushko-mlnx <vadymh@nvidia.com>
@vadymhlushko-mlnx vadymhlushko-mlnx force-pushed the 202205-generate-dump-optimization-2 branch from f087b8a to 4a36e94 Compare March 9, 2023 14:24
@liat-grozovik
Copy link
Collaborator

@yxieca please refer to this backport as an important enhancement to 202205

@yxieca yxieca merged commit 90e00ea into sonic-net:202205 Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants