[sonic-utilities/scripts] Fixing FP ports issue #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yxieca Can you please review this PR |
qiluo-msft
reviewed
Jun 15, 2018
scripts/reboot
Outdated
| if [[ "$EUID" -ne 0 ]] | ||
| then | ||
| echo "Please run as root" | ||
| exit |
There was a problem hiding this comment.
exit [](start = 2, length = 4)
exit with error code
qiluo-msft
reviewed
Jun 15, 2018
scripts/reboot
Outdated
| # Check root privileges | ||
| if [[ "$EUID" -ne 0 ]] | ||
| then | ||
| echo "Please run as root" |
There was a problem hiding this comment.
echo [](start = 2, length = 4)
output to stderr?
This commit fixes the Front Panel Ports not coming up during cold reboot and traffic being sent at line rate. The root cause was the PCIe bus error which was caused because of the host side not doing a gracefull shutdown calling bcm_shutdown and soc_shutdown. The fix will call the gracefull shutdown of syncd during reboot which in turns calls the bcm_shutdown and soc_shutdown. Additionally added the check to make sure the script will run only when it has root privileges otherwise it will quit. Verified the fix by running traffic at line rate 40G from Ixia and rebooted using script multiple times and traffic was successfully forwarded after every reboot. Signed-off-by: Harish Venkatraman <Harish_Venkatraman@dell.com>
66894a4 to
94ea615
Compare
yxieca
approved these changes
Jun 15, 2018
lguohan
pushed a commit
that referenced
this pull request
Dec 26, 2018
This commit fixes the Front Panel Ports not coming up during cold reboot and traffic being sent at line rate. The root cause was the PCIe bus error which was caused because of the host side not doing a gracefull shutdown calling bcm_shutdown and soc_shutdown. The fix will call the gracefull shutdown of syncd during reboot which in turns calls the bcm_shutdown and soc_shutdown. Additionally added the check to make sure the script will run only when it has root privileges otherwise it will quit. Verified the fix by running traffic at line rate 40G from Ixia and rebooted using script multiple times and traffic was successfully forwarded after every reboot. Signed-off-by: Harish Venkatraman <Harish_Venkatraman@dell.com>
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 18, 2022
Update sonic-linux-kernel submodule to updated 202012 branch. This brings in the following commits.... ``` e97f9fc [202012] Add upstreamed patches which backport support for registers for CPLD PNs (sonic-net#275) 58abcdc Merge pull request sonic-net#267 from Staphylo/202012-log-buf-len 3f16f4f Merge pull request sonic-net#268 from Staphylo/202012-emmc-fixes a120ae7 Apply kernel patches to fix emmc unreliability 5f4a3f3 Increase log_buf_len to 1M for all architecture ```
mihirpat1
pushed a commit
to mihirpat1/sonic-utilities
that referenced
this pull request
Sep 15, 2023
* [CMIS]Fix low-power to high power mode transition * Remove python2 tests * Improve code coverage * Parametrize the test * Improve code coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the Front Panel Ports not coming up during
cold reboot and traffic being sent at line rate. The root cause
was the PCIe bus error which was caused because of the host
side not doing a gracefull shutdown calling bcm_shutdown and
soc_shutdown. The fix will call the gracefull shutdown of syncd
during reboot which in turns calls the bcm_shutdown and soc_shutdown.
Additionally added the check to make sure the script will run only when
it has root privileges otherwise it will quit.
Verified the fix by running traffic at line rate 40G from Ixia and
rebooted using script multiple times and traffic was successfully
forwarded after every reboot.
Signed-off-by: Harish Venkatraman Harish_Venkatraman@dell.com
- What I did
- How I did it
- How to verify it
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)
-->