Change db_migrator major version on master branch from version 2 to 3 #2272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yxieca
approved these changes
Jul 20, 2022
yxieca
pushed a commit
that referenced
this pull request
Jul 22, 2022
…#2272) To add room for db_migrator changes in 202012 branch, changed the major version on master/202205 branches from "2" to "3" This change is needed: 1. Since the existing master/202205 db versions cannot be backported to 202012 as they are not relevant to 202012. Current latest DB version for 202012 is 2_0_0, to add newer versions 2_0_1 cannot be added as it is already used for master/202205 branch. 2. Since master/202205 branches should incremented major version that was reserved for 202012. Since 202205 used same major version as 202012, there is no place for migrator changes to go into 202012 branch. Changed major version on migrator script. Updated test files. Signed-off-by: Vaibhav Hemant Dixit <vaibhav.dixit@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
To add room for db_migrator changes in 202012 branch, changed the major version on master/202205 branches from "2" to "3"
This is needeed:
2_0_0, to add newer versions2_0_1cannot be added as it is already used for master/202205 branch.Ideally, master/202205 branches should not have incremented major version that was reserved for 202012. Since 202205 used same major version as 202012, these sub-optimal fix (changing already set DB versions) is necessary.
How I did it
Changed major version.
Changed test files.
How to verify it
Ran unit tests locally.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)