[202012] Fix migration of pfcwd_sw_enable
#2204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bingwang <wang.bing@microsoft.com>
Signed-off-by: bingwang <wang.bing@microsoft.com>
lolyu
approved these changes
Jun 9, 2022
Signed-off-by: bingwang <wang.bing@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: bingwang wang.bing@microsoft.com
What I did
This PR is to fix a bug in
migrate_pfcwd_sw_enable_table.As
migrate_pfcwd_sw_enable_tableis a step ofcommon_migration_ops, it's always called in any version.Even if the key
pfcwd_sw_enableis present, the script still overwrite it. This is unexpected.This PR addressed the issue by checking the existence of
pfcwd_sw_enablebefore adding it.How I did it
Check the existence of
pfcwd_sw_enablebefore adding it.How to verify it
Verified by vstest.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)