[201911][reboot] Remove exec from platform_reboot call to prevent reboot hang #1881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Port fix from master to stop pmon service for reboot and soft-reboot
yxieca
approved these changes
Oct 18, 2021
|
has this been verify on 201911 ? |
|
@abdosi I verified the reboot and soft-reboot script on top of 20191130.78. |
abdosi
approved these changes
Oct 26, 2021
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 18, 2022
* d240291 Update port_rates & rif_rates lua scripts to convert poll_interval to MS (sonic-net#1855) * a71a5d3 [acl mirror action] Mirror session ref count fix at acl rule attachment (sonic-net#1761) * 197f427 Fix vs test failure in test_buffer_traditional (sonic-net#1881) * 8471f42 Revert "[debugcounterorch] check if counter type is supported before querying… (sonic-net#1789)" (sonic-net#1884) Signed-off-by: Volodymyr Samotiy <volodymyrs@nvidia.com>
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
Commits on Oct 26, 2021 Remove exec from platform_reboot call to prevent reboot hang (sonic-net#1881) 066b5ad Commits on Nov 17, 2021 [fdbshow]: Handle FDB cleanup gracefully. (sonic-net#1918) c80321c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port fix from master to stop pmon service for reboot and soft-reboot
What I did
Remove exec from the platform_reboot call to handle any hang issue during reboot
Port missing fix from master : stop pmon service for reboot and soft-reboot
How I did it
Remove "exec" from " exec ${DEVPATH}/${PLATFORM}/${PLAT_REBOOT} $@"
How to verify it
Perform sudo reboot after DE initializing the platfom driver and see if the device gracefully reboots by /sbin/reboot after failing on platform_reboot.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)