Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[config] Add EXP-to-TC map to clear_qos #1875

Merged
merged 6 commits into from
Nov 2, 2021
Merged

[config] Add EXP-to-TC map to clear_qos #1875

merged 6 commits into from
Nov 2, 2021

Conversation

TACappleman
Copy link
Contributor

What I did

Added EXP to TC map to tables affected by clear_qos command

How I did it

Found references to DSCP to TC map, added EXP to TC map in same place

How to verify it

Run clear_qos with EXP to TC map present

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

@TACappleman
Copy link
Contributor Author

HLD: sonic-net/SONiC#844

@TACappleman TACappleman mentioned this pull request Oct 19, 2021
Merged
abdosi
abdosi requested changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@abdosi abdosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not matching design document. https://github.com/Azure/SONiC/pull/844/files
It is define as CFG_MPLS_TC_TO_TC_MAP_TABLE_NAME in design doc.

@TACappleman
Copy link
Contributor Author

This is not matching design document. https://github.com/Azure/SONiC/pull/844/files It is define as CFG_MPLS_TC_TO_TC_MAP_TABLE_NAME in design doc.

Fixed

@TACappleman
Copy link
Contributor Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@abdosi
Copy link
Contributor

abdosi commented Oct 26, 2021 •
edited
Loading

can we add unit test case to cover cases ? What happens if there is no MPLS EXP table and we do clear qos ? To make sure this change is backward compatible

@TACappleman
Copy link
Contributor Author

Added to qos reload test (which covers the clear_qos command)

@abdosi
Copy link
Contributor

abdosi commented Oct 26, 2021

Added to qos reload test (which covers the clear_qos command)

what happens if there is no MPLS EXP table and we do clear qos ?

@TACappleman
Copy link
Contributor Author

Added to qos reload test (which covers the clear_qos command)

what happens if there is no MPLS EXP table and we do clear qos ?

Same as all the other tables - will just have no effect

@TACappleman
Copy link
Contributor Author

I've changed the tests so that only 1 of them (the non-multi-ASIC) includes the new map, so that tests clearing qos when no EXP-TC map is set

@TACappleman
Copy link
Contributor Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@TACappleman
Copy link
Contributor Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@abdosi abdosi merged commit 474bdbf into sonic-net:master Nov 2, 2021
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 18, 2022
@bingwang-ms
[submodule]: Update sonic-swss (#8574)
813ed88 
d29a49a [ACL] Match TCP protocol while matching TCP_FLAG (sonic-net#1854)
2569ad9 Fix sFlow sampling-rate and admin-state (sonic-net#1728)
8908a8f Change rif_rates.lua and port_rates.lua scripts to calculate rates correct (sonic-net#1848)
b42c2fb [VS Test] Skip flaky tests (sonic-net#1875)

Signed-off-by: bingwang <bingwang@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdosi abdosi abdosi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TACappleman @mssonicbld @abdosi