[show techsupport] fix bash errors in generate_dump script #1844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
smaheshm
reviewed
Sep 28, 2021
| @@ -195,8 +195,9 @@ save_cmd() { | |||
| if $NOOP; then | |||
| echo "${timeout_cmd} $cmd $redirect '$filepath'" | |||
| else | |||
| eval "${timeout_cmd} $cmd" "$redirect" "$filepath" | |||
| if [ $? -ne 0 ]; then | |||
There was a problem hiding this comment.
This code looks good to me. Wondering where does it fail.
There was a problem hiding this comment.
oh, I see, it can fail when there's timeout.
There was a problem hiding this comment.
Didn't look deep into it. One possibility is that command timed out?
There was a problem hiding this comment.
If you were asking what the issue with this old structure. if line 198 returns non-zero code, then it would trigger the error handling and bypass the handling at 199.
|
@qiluo-msft you are right, there are more issues in the script that didn't get caught by test but code structure also needs to be updated. This PR by itself fixes the test issue. I'll add another PR to address more code structural issues. |
qiluo-msft
pushed a commit
that referenced
this pull request
Sep 29, 2021
What I did Fix: sonic-net/sonic-buildimage#8850 Issue was introduced by #1723, #1833, and #1843 (pending merge) The error_handler is a great idea but the bash script needs to be error free first. How I did it Fix bash script errors. How to verify it run show techsupport test.. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
vivekrnv
pushed a commit
to vivekrnv/sonic-utilities
that referenced
this pull request
Oct 16, 2021
…#1844) What I did Fix: sonic-net/sonic-buildimage#8850 Issue was introduced by sonic-net#1723, sonic-net#1833, and sonic-net#1843 (pending merge) The error_handler is a great idea but the bash script needs to be error free first. How I did it Fix bash script errors. How to verify it run show techsupport test.. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
praveen-li
pushed a commit
to praveen-li/sonic-utilities
that referenced
this pull request
Feb 8, 2022
…#1844) What I did Fix: sonic-net/sonic-buildimage#8850 Issue was introduced by sonic-net#1723, sonic-net#1833, and sonic-net#1843 (pending merge) The error_handler is a great idea but the bash script needs to be error free first. How I did it Fix bash script errors. How to verify it run show techsupport test.. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 18, 2022
* 41dfaad 2021-08-02 | Bridge mac setting, fix statedb time format (sonic-net#1844) (HEAD, origin/202012) [Prince Sunny] Signed-off-by: Guohan Lu <lguohan@gmail.com>
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 18, 2022
0b5f90b (HEAD -> 202012, origin/202012) [show techsupport] fix bash errors in generate_dump script (sonic-net#1844) 388c50c [202012][warmboot] Add new preboot health check: verify db integrity (sonic-net#1839) d73dc98 [config] support for configuring muxcable to standby mode of operation (sonic-net#1837) Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fix: sonic-net/sonic-buildimage#8850
Issue was introduced by #1723, #1833, and #1843 (pending merge)
The error_handler is a great idea but the bash script needs to be error free first.
How I did it
Fix bash script errors.
How to verify it
run show techsupport test..
Signed-off-by: Ying Xie ying.xie@microsoft.com